From 6b1fd05d144e399dd617cf48281c77d4ea116747 Mon Sep 17 00:00:00 2001 From: VE10-Sanjeev Date: Fri, 17 Nov 2023 17:10:48 +0530 Subject: [PATCH 1/2] Invoice Fixes : ps --- app/Controllers/Invoice.php | 44 +++++++++++++++++++------------------ app/Views/invoice_form.php | 44 +++++++++++++++++++++++++++---------- 2 files changed, 56 insertions(+), 32 deletions(-) diff --git a/app/Controllers/Invoice.php b/app/Controllers/Invoice.php index d7ec43f2..6cb2205c 100644 --- a/app/Controllers/Invoice.php +++ b/app/Controllers/Invoice.php @@ -173,10 +173,10 @@ class Invoice extends BaseController 'tax' => (int)$this->request->getPost('invoice_tax'), 'discount' => (int)$this->request->getPost('discount'), 'total_amount' => (int)$this->request->getPost('grand_total'), - 'shipping_charge' => (int)$this->request->getPost('shippingCharges'), - 'shipping_label' =>$this->request->getPost('shippingChargesLabel'), + 'shipping_charge' => ((int)$invoiceType === 1) ? (int)$this->request->getPost('shippingCharges') : NULL, + 'shipping_label' => ((int)$invoiceType === 1) ? $this->request->getPost('shippingChargesLabel') : NULL, 'order_number' => $this->request->getPost('order_number'), - 'payment_method' =>$this->request->getPost('payment_method'), // "Credit Card," "Cash on Delivery," "PayPal","PayTm","Gpay" + 'payment_method' => $invoice_status !== 'Draft' ? $this->request->getPost('payment_method') : NULL, // "Credit Card," "Cash on Delivery," "PayPal","PayTm","Gpay" 'payment_status' => 'Pending', //"Paid," "Pending," "Failed," "Refunded," "Canceled," "Authorized," and "Completed." 'event_id' => (int)$this->request->getPost('event_id'), 'business_id' => (int)get_business_id(), @@ -327,25 +327,27 @@ class Invoice extends BaseController $invoiceitem_arr = []; if ($count > 0) { for ($x = 0; $x < $count; $x++) { - $invoiceitem_arr[$x]['invoice_id'] = $id; - $invoiceitem_arr[$x]['product'] = (int)$requestData['item_details'][$x]; - $invoiceitem_arr[$x]['quantity'] = (int)$requestData['quantity'][$x]; - $invoiceitem_arr[$x]['tax'] = (int)$requestData['tax'][$x]; - $invoiceitem_arr[$x]['unit_price'] = (int)$requestData['rate'][$x]; - $invoiceitem_arr[$x]['subtotal'] = (int)$requestData['amount'][$x]; - $invoiceitem_arr[$x]['discount_amount'] = (int)$requestData['discount_amount'][$x]; - $invoiceitem_arr[$x]['discount_type'] =$requestData['discount_type'][$x]; - if (!empty($requestData['from_subscription'])) { - $invoiceitem_arr[0]['from_subscription'] = $requestData['from_subscription']; + if(!empty($requestData['item_details'][$x])){ + $invoiceitem_arr[$x]['invoice_id'] = $id; + $invoiceitem_arr[$x]['product'] = (int)$requestData['item_details'][$x]; + $invoiceitem_arr[$x]['quantity'] = (int)$requestData['quantity'][$x]; + $invoiceitem_arr[$x]['tax'] = (int)$requestData['tax'][$x]; + $invoiceitem_arr[$x]['unit_price'] = (int)$requestData['rate'][$x]; + $invoiceitem_arr[$x]['subtotal'] = (int)$requestData['amount'][$x]; + $invoiceitem_arr[$x]['discount_amount'] = (int)$requestData['discount_amount'][$x]; + $invoiceitem_arr[$x]['discount_type'] =$requestData['discount_type'][$x]; + if (!empty($requestData['from_subscription'])) { + $invoiceitem_arr[0]['from_subscription'] = $requestData['from_subscription']; + } + + if (!empty($requestData['to_subscription'])) { + $invoiceitem_arr[0]['to_subscription'] = $requestData['to_subscription']; + } + $invoiceitem_arr[$x]['created_by'] = (int)get_logged_user_id(); + $invoiceitem_arr[$x]['updated_by'] = (int)get_logged_user_id(); + $invoiceitem_arr[$x]['isactive'] = 1; + $invoiceitem_arr[$x]['invoice_child_id'] = $itemid[$x]; } - - if (!empty($requestData['to_subscription'])) { - $invoiceitem_arr[0]['to_subscription'] = $requestData['to_subscription']; - } - $invoiceitem_arr[$x]['created_by'] = (int)get_logged_user_id(); - $invoiceitem_arr[$x]['updated_by'] = (int)get_logged_user_id(); - $invoiceitem_arr[$x]['isactive'] = 1; - $invoiceitem_arr[$x]['invoice_child_id'] = $itemid[$x]; } $statement = $model->saveInvoiceItemDetails($invoiceitem_arr); } diff --git a/app/Views/invoice_form.php b/app/Views/invoice_form.php index ba664026..af660c8e 100644 --- a/app/Views/invoice_form.php +++ b/app/Views/invoice_form.php @@ -222,7 +222,7 @@
- min="1" > + min="0" >
@@ -268,6 +268,7 @@