'required|integer', 'activity_type' => 'required|in_list[Call,Email,Meeting,Visit,Demo,Share Docs,To Do]', 'notes' => 'required', 'scheduled_date' => 'required', 'assigned_to' => 'required|integer', 'status' => 'in_list[pending,completed]', ]; protected $validationMessages = [ 'lead_id' => [ 'required' => 'Lead ID is required', ], 'activity_type' => [ 'required' => 'Activity type is required', ], 'notes' => [ 'required' => 'Activity notes are required', ], ]; protected $skipValidation = false; /** * Get sales_activities by lead with user details */ public function getActivitiesByLead($leadId, $status = null) { // Convert the INT id to a string, then wrap it in JSON quotes to match ["5", "11"] $subQuery = "(SELECT GROUP_CONCAT(up2.first_name SEPARATOR ', ') FROM user_profiles up2 WHERE JSON_CONTAINS(sales_activities.additional_assigned_ids, JSON_QUOTE(CAST(up2.id AS CHAR))) ) as additional_assigned_names"; $builder = $this->select("sales_activities.*, up1.first_name as assigned_to_name, $subQuery") ->join('user_profiles as up1', 'up1.id = sales_activities.assigned_to', 'left') ->where('sales_activities.lead_id', $leadId); if ($status) { $builder->where('sales_activities.status', $status); } return $builder->orderBy('sales_activities.scheduled_date', 'DESC')->findAll(); } /** * Get all sales_activities with filters */ public function getActivitiesWithFiltersOLD($filters = [], $limit = 10, $offset = 0) { $this->select('sales_activities.*, sales_actual_leads.company_name, user_profiles.first_name as assigned_to_name') ->join('sales_actual_leads', 'sales_actual_leads.lead_id = sales_activities.lead_id', 'left') ->join('user_profiles', 'user_profiles.id = sales_activities.assigned_to', 'left'); if (!empty($filters['status'])) { $this->where('sales_activities.status', $filters['status']); } if (!empty($filters['activity_type'])) { $this->where('sales_activities.activity_type', $filters['activity_type']); } // if (!empty($filters['assigned_to'])) { // $this->where('sales_activities.assigned_to', $filters['assigned_to']); // } if (!empty($filters['assigned_to'])) { $assigned_to = $filters['assigned_to']; // If it's already an array, use it. If it's a string, explode it into an array. $assignedToIds = is_array($assigned_to) ? $assigned_to : explode(',', $assigned_to); // Now it is guaranteed to be an array, making whereIn perfectly safe $this->whereIn('sales_activities.assigned_to', $assignedToIds); } if (!empty($filters['date_from'])) { $this->where('sales_activities.scheduled_date >=', $filters['date_from']); } if (!empty($filters['date_to'])) { $this->where('sales_activities.scheduled_date <=', $filters['date_to']); } if (!empty($filters['search'])) { $this->groupStart() ->like('sales_actual_leads.company_name', $filters['search']) ->orLike('sales_actual_leads.email', $filters['search']) ->orLike('sales_actual_leads.phone', $filters['search']) ->orLike('user_profiles.first_name', $filters['search']) ->groupEnd(); } $this->orderBy('sales_activities.created_at', 'DESC'); $total = $this->countAllResults(false); $data = $this->findAll($limit, $offset); return ['data' => $data,'total' => $total]; // return [ // 'data' => $builder->orderBy('sales_activities.scheduled_date', 'DESC') // ->limit($limit, $offset)->findAll(), // 'total' => $builder->countAllResults(false) // ]; } public function getActivitiesWithFilters($filters = [], $limit = 10, $offset = 0) { // 1. Initial Selection $builder = $this->select(" sales_activities.*, sales_actual_leads.company_name, up1.first_name as assigned_to_name, GROUP_CONCAT(DISTINCT up2.first_name SEPARATOR ', ') as additional_assigned_names ") ->join('sales_actual_leads', 'sales_actual_leads.lead_id = sales_activities.lead_id', 'left') ->join('user_profiles as up1', 'up1.id = sales_activities.assigned_to', 'left'); // 2. The JSON Join for additional names // Only attempts join if the string looks like a JSON array $builder->join('user_profiles as up2', " sales_activities.additional_assigned_ids IS NOT NULL AND sales_activities.additional_assigned_ids != '' AND sales_activities.additional_assigned_ids != '[]' AND JSON_VALID(sales_activities.additional_assigned_ids) AND JSON_CONTAINS(sales_activities.additional_assigned_ids, JSON_QUOTE(CAST(up2.id AS CHAR))) ", 'left'); // 3. Apply Filters if (!empty($filters['status'])) { $builder->where('sales_activities.status', $filters['status']); } if (!empty($filters['activity_type'])) { $builder->where('sales_activities.activity_type', $filters['activity_type']); } if (!empty($filters['assigned_to'])) { $assignedToIds = is_array($filters['assigned_to']) ? $filters['assigned_to'] : explode(',', $filters['assigned_to']); $builder->whereIn('sales_activities.assigned_to', $assignedToIds); } if (!empty($filters['search'])) { $builder->groupStart() ->like('sales_actual_leads.company_name', $filters['search']) ->orLike('up1.first_name', $filters['search']) ->groupEnd(); } // 4. Grouping & Ordering $builder->groupBy('sales_activities.activity_id'); $builder->orderBy('sales_activities.created_at', 'DESC'); // 5. Calculate Counts (using a clean builder to avoid the syntax error) $counts = $this->getActivityStatusCounts($filters); // 6. Get Data and Total // Use true for countAllResults to get an accurate count of grouped rows $totalCountQuery = clone $builder; $total = $totalCountQuery->countAllResults(false); $data = $builder->findAll($limit, $offset); return [ 'data' => $data, 'total' => $total, 'counts' => $counts ]; } /** * Helper function to get counts without breaking the main query syntax */ private function getActivityStatusCounts($filters) { $validStatuses = ['pending', 'completed']; $counts = ['all' => 0, 'pending' => 0, 'completed' => 0]; foreach ($validStatuses as $status) { $query = $this->db->table('sales_activities')->where('status', $status); if (!empty($filters['assigned_to'])) { $ids = is_array($filters['assigned_to']) ? $filters['assigned_to'] : explode(',', $filters['assigned_to']); $query->whereIn('assigned_to', $ids); } $counts[$status] = $query->countAllResults(); } $counts['all'] = $counts['pending'] + $counts['completed']; return $counts; } /** * Complete an activity */ public function completeActivity($activityId, $completionData) { return $this->update($activityId, [ 'status' => 'completed', 'completion_notes' => $completionData['completion_notes'], 'completed_date' => date('Y-m-d H:i:s'), 'updated_by' => $completionData['updated_by'] ?? null ]); } /** * Get pending sales_activities count by user */ public function getPendingActivitiesCount($userId) { return $this->where('assigned_to', $userId) ->where('status', 'pending') ->where('scheduled_date <=', date('Y-m-d H:i:s')) ->countAllResults(); } /** * Get upcoming sales_activities for a user */ public function getUpcomingActivities($userId, $days = 7, $limit = 10) { $endDate = date('Y-m-d H:i:s', strtotime("+{$days} days")); return $this->select('sales_activities.*, sales_actual_leads.company_name') ->join('sales_actual_leads', 'sales_actual_leads.lead_id = sales_activities.lead_id', 'left') ->where('sales_activities.assigned_to', $userId) ->where('sales_activities.status', 'pending') ->where('sales_activities.scheduled_date <=', $endDate) ->orderBy('sales_activities.scheduled_date', 'ASC') ->limit($limit) ->findAll(); } /** * Get activity timeline for a lead */ public function getActivityTimeline($leadId) { return $this->select('sales_activities.*, user_profiles.first_name as assigned_to_name') ->join('user_profiles', 'user_profiles.id = sales_activities.assigned_to', 'left') ->where('sales_activities.lead_id', $leadId) ->orderBy('sales_activities.scheduled_date', 'DESC') ->findAll(); } }